Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency addition to Joshua-Decoder/Joshua/pom.xml #239

Open
chrismattmann opened this issue Jan 19, 2016 · 9 comments
Open

Dependency addition to Joshua-Decoder/Joshua/pom.xml #239

chrismattmann opened this issue Jan 19, 2016 · 9 comments

Comments

@chrismattmann
Copy link
Contributor

args4j args4j 2.32

Joshua-Decoder/Joshua committer please add this dependency to pom.xml
thank you/
Martin

@chrismattmann
Copy link
Contributor Author

from the Apache Incubator general@ discussion.

@lewismc
Copy link
Contributor

lewismc commented Feb 12, 2016

@mjpost Joshua still builds with Ant right? Is there a specific requirement for the Maven pom.xml?

@mjpost
Copy link
Member

mjpost commented Feb 12, 2016

Yep, it's ant-based. It's in the Ivy dependency file, lib/ivy.xml.

@lewismc
Copy link
Contributor

lewismc commented Feb 12, 2016

Ack
So you want me to file a ticket to remove he Maven material?

On Friday, February 12, 2016, Matt Post notifications@github.com wrote:

Yep, it's ant-based. It's in the Ivy dependency file, lib/ivy.xml.


Reply to this email directly or view it on GitHub
#239 (comment)
.

Lewis

@mjpost
Copy link
Member

mjpost commented Feb 12, 2016

I don't think we need to remove it. Doesn't Maven replace Ivy? We could transition at some point.

@lewismc
Copy link
Contributor

lewismc commented Feb 12, 2016

Oh, so you want to move away from Ant + Ivy to Maven?
If you want I can work on that one?

On Fri, Feb 12, 2016 at 1:08 PM, Matt Post notifications@github.com wrote:

I don't think we need to remove it. Doesn't Maven replace Ivy? We could
transition at some point.


Reply to this email directly or view it on GitHub
#239 (comment)
.

Lewis

@mjpost
Copy link
Member

mjpost commented Feb 13, 2016

I wouldn't say I want to, but am definitely willing if someone wants to make the case for straight Maven over ant + ivy. In general, I prefer stability in build tools and am wary of jumping from ship to ship, but if there's a good case for it, I'd happily hear it. I've had some pressure to do so from another source, so maybe it'd be good to consider.

@lewismc
Copy link
Contributor

lewismc commented Feb 13, 2016

What an understatement this was.
In all honesty I think that this is a pretty large job. The number of Git submodules, different languages, etc. I think it needs to stay open and serious thought needs to go into which build system is the best.

On Fri, Feb 12, 2016 at 7:03 PM, Matt Post notifications@github.com wrote:

I wouldn't say I want to, but am definitely willing if someone wants to
make the case for straight Maven over ant + ivy. In general, I prefer
stability in build tools and am wary of jumping from ship to ship, but if
there's a good case for it, I'd happily hear it. I've had some pressure to
do so from another source, so maybe it'd be good to consider.


Reply to this email directly or view it on GitHub
#239 (comment)
.

Lewis

@lewismc
Copy link
Contributor

lewismc commented Feb 25, 2016

This issue can be closed for the time being. it is not required as Maven is not the primary build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants