Merge pull request #21 from joshuaalpuerto/wip/add-unit-test-app-layer

add unit test app layer

package.json

@@ -72,6 +72,8 @@
     "npx": "10.2.0",
     "pre-commit": "1.2.2",
     "semantic-release": "15.4.1",
+    "sinon": "5.0.7",
+    "sinon-chai": "3.0.0",
     "supertest": "3.0.0",
     "travis-deploy-once": "5.0.0"
   },
@@ -85,7 +87,8 @@
       "expect",
       "describe",
       "it",
-      "config"
+      "config",
+      "beforeEach"
     ]
   },
   "repository": {

src/app/company/delete.js

@@ -4,19 +4,18 @@
 module.exports = ({ companyRepository }) => {
   // code for getting all the items
   const remove = ({ id }) => {
-    return new Promise(async (resolve, reject) => {
-      try {
-        const companyEntity = await companyRepository.update({
+    return Promise
+      .resolve()
+      .then(() =>
+        companyRepository.update({
           isDeleted: 1
         }, {
           where: { id }
         })
-
-        resolve(companyEntity)
-      } catch (error) {
-        reject(error)
-      }
-    })
+      )
+      .catch((error) => {
+        throw new Error(error)
+      })
   }
 
   return {

src/app/company/post.js

@@ -9,16 +9,15 @@ const { Company } = require('src/domain/company')
 module.exports = ({ companyRepository }) => {
   // code for getting all the items
   const create = ({ body }) => {
-    return new Promise(async (resolve, reject) => {
-      try {
+    return Promise
+      .resolve()
+      .then(() => {
         const company = Company(body)
-        const companyEntity = await companyRepository.create(company)
-
-        resolve(companyEntity)
-      } catch (error) {
-        reject(error)
-      }
-    })
+        return companyRepository.create(company)
+      })
+      .catch((error) => {
+        throw new Error(error)
+      })
   }
 
   return {

src/app/user/delete.js

@@ -4,19 +4,18 @@
 module.exports = ({ userRepository }) => {
   // code for getting all the items
   const remove = ({ id }) => {
-    return new Promise(async (resolve, reject) => {
-      try {
-        const userEntity = await userRepository.update({
+    return Promise
+      .resolve()
+      .then(() =>
+        userRepository.update({
           isDeleted: 1
         }, {
           where: { id }
         })
-
-        resolve(userEntity)
-      } catch (error) {
-        reject(error)
-      }
-    })
+      )
+      .catch((error) => {
+        throw new Error(error)
+      })
   }
 
   return {

src/app/user/post.js

@@ -8,20 +8,19 @@ const { User } = require('src/domain/user')
 module.exports = ({ userRepository }) => {
   // code for getting all the items
   const create = ({ body }) => {
-    return new Promise(async (resolve, reject) => {
-      try {
+    return Promise
+      .resolve()
+      .then(() => {
         const password = body.password || 'test'
         const entity = Object.assign({}, body, {
           password
         })
         const user = User(entity)
-        const userEntity = await userRepository.create(user)
-
-        resolve(userEntity)
-      } catch (error) {
-        reject(error)
-      }
-    })
+        return userRepository.create(user)
+      })
+      .catch((error) => {
+        throw new Error(error)
+      })
   }
 
   return {

test/api/companies/delete_companies.spec.js

@@ -1,15 +1,21 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 const companyRepository = require('src/infra/repositories/company')
 
 describe('Routes: DELETE Companies', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
 
-  const CompanyModel = repository('companies')
-  const CompanyUseCase = CompanyModel(companyRepository)
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
+  const CompanyUseCase = compose(
+    repository(companyRepository),
+    models
+  )('companies')
 
   const signIn = app.resolve('jwt').signin()
   let token

test/api/companies/get_companies.spec.js

@@ -1,15 +1,21 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 const companyRepository = require('src/infra/repositories/company')
 
 describe('Routes: GET Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
 
-  const CompanyModel = repository('companies')
-  const CompanyUseCase = CompanyModel(companyRepository)
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
+  const CompanyUseCase = compose(
+    repository(companyRepository),
+    models
+  )('companies')
 
   const signIn = app.resolve('jwt').signin()
   let token

test/api/companies/post_companies.spec.js

@@ -1,15 +1,21 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 const companyRepository = require('src/infra/repositories/company')
 
 describe('Routes: POST Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
 
-  const CompanyModel = repository('companies')
-  const CompanyUseCase = CompanyModel(companyRepository)
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
+  const CompanyUseCase = compose(
+    repository(companyRepository),
+    models
+  )('companies')
 
   const signIn = app.resolve('jwt').signin()
   let token

test/api/companies/put_companies.spec.js

@@ -1,15 +1,21 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 const companyRepository = require('src/infra/repositories/company')
 
 describe('Routes: PUT Companies', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
 
-  const CompanyModel = repository('companies')
-  const CompanyUseCase = CompanyModel(companyRepository)
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
+  const CompanyUseCase = compose(
+    repository(companyRepository),
+    models
+  )('companies')
 
   const signIn = app.resolve('jwt').signin()
   let token

test/api/token.spec.js

@@ -1,11 +1,15 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 
 describe('Routes: Login', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
+
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
 
   beforeEach((done) => {
     // we need to add user before we can request our token

test/api/users/delete_users.spec.js

@@ -1,11 +1,16 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 
 describe('Routes: DELETE Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
+
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
   const signIn = app.resolve('jwt').signin()
   let token
   let userId

test/api/users/get_users.spec.js

@@ -1,11 +1,16 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 
 describe('Routes: GET Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
+
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
   const signIn = app.resolve('jwt').signin()
   let token
 

test/api/users/post_users.spec.js

@@ -1,11 +1,16 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 
 describe('Routes: POST Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
+
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
   const signIn = app.resolve('jwt').signin()
   let token
 

test/api/users/put_users.spec.js

@@ -1,11 +1,16 @@
 /* eslint-env mocha */
-const { repository } = require('test/factory')
+const { compose } = require('ramda')
+const { models, repository } = require('test/factory')
 const userRepository = require('src/infra/repositories/user')
 
 describe('Routes: PUT Users', () => {
   const BASE_URI = `/api/${config.version}`
-  const UserModel = repository('users')
-  const UserUseCase = UserModel(userRepository)
+
+  const UserUseCase = compose(
+    repository(userRepository),
+    models
+  )('users')
+
   const signIn = app.resolve('jwt').signin()
   let token
   let userId

test/factory.js

@@ -1,15 +1,17 @@
 /**
  * We need to find a way to user the repositories for our test that it we will have minimum impact once we change our ORM or our DATABASE
  */
-const { compose } = require('ramda')
+const { curry } = require('ramda')
 
  // we will call each repo on thier test  cases  here we will just compose the items.
 
-const repository = (model) => {
-  const entity = app.resolve('database').models[model]
-  return (repo) => compose(repo)(entity)
-}
+const models = (name) => app.resolve('database').models[name]
+
+const repository = curry((repo, model) => {
+  return repo(model)
+})
 
 module.exports = {
+  models,
   repository
 }