Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

247 getquote tiingo #250

Merged
merged 8 commits into from
Nov 10, 2018
Merged

247 getquote tiingo #250

merged 8 commits into from
Nov 10, 2018

Conversation

ethanbsmith
Copy link
Contributor

No description provided.

@ethanbsmith
Copy link
Contributor Author

solves #247

@ethanbsmith @joshuaulrich
Add Tiingo as getQuote() source
49829d7 
Initial version. Waiting on feedback about correct batch size from
Tiingo.

See #247.
@ethanbsmith @joshuaulrich
Import all symbols if Symbols = NULL
333fbc4 
Add support for getting all symbols with NULL symbols parameter.

See #247.
@ethanbsmith @joshuaulrich
Move column fixups back into batch loop
467d76b 
See #247.
@joshuaulrich
Copy link
Owner

Thanks for the PR! There are a few cosmetic things I would change, and I would like to refactor to avoid the code duplication in the is.null(Symbols) if/else blocks. I can take care of these if you can give me push access to this branch.

I would also like to rebase to merge your two 'fixup' commits, and amend some of the commit messages. Is that okay with you? It might cause you some grief when you update your local copy.

@ethanbsmith
Copy link
Contributor Author

have at it. i have "allow edits for maintainers" checked. is that what you need?

@joshuaulrich
Copy link
Owner

Yep, thanks!

ethanbsmith and others added 4 commits November 10, 2018 08:01
@ethanbsmith @joshuaulrich
Remove duplicate code for (non)null Symbols
228d041 
See #247.
@joshuaulrich
Indent to 2 spaces, correct typos
e5d5fac
@joshuaulrich
Fix column name typo and avoid $ subset
b7c8597 
The `$` data.frame subset method does partial column name matching,
and returns NULL if the column name is not found. The `[` data.frame
subset method will throw an error if the column name is not found.
@joshuaulrich
Fix URL if batch size is not multiple of 100
1e88e43 
`min(Symbols,  i + batch.size - 1L)` would always return the second
argument because Symbols is a character vector. This should be
`length(Symbols)`.

Calculate the last batch observation index once at the top of the loop
and use it in the printed message and when creating the URL.

See #247.
@joshuaulrich joshuaulrich mentioned this pull request Nov 10, 2018
Closed
@joshuaulrich joshuaulrich merged commit b96afcb into joshuaulrich:master Nov 10, 2018
joshuaulrich added a commit that referenced this pull request Nov 10, 2018
@joshuaulrich
Merge branch '247_getquote_tiingo'
8ccf6ee 
Fixes #247, fixes #250.
@joshuaulrich joshuaulrich added this to the Release 0.4-14 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.4-14
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanbsmith @joshuaulrich