rethrow errors thrown during effectFn and cleanup #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dmaskasky
force-pushed
the
effect-error
branch
from
224579b to
61fd096
Compare
dmaskasky
changed the title
Brooooooklyn
referenced
this pull request
in toeverything/AFFiNE
Mar 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/main/clients/client-s3) ([source](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3)) | [`3.523.0` -> `3.525.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-s3/3.523.0/3.525.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@node-rs/jsonwebtoken](https://github.com/napi-rs/node-rs) | [`^0.4.0` -> `^0.5.0`](https://renovatebot.com/diffs/npm/@node-rs%2fjsonwebtoken/0.4.0/0.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nx/vite](https://nx.dev) ([source](https://github.com/nrwl/nx/tree/HEAD/packages/vite)) | [`18.0.5` -> `18.0.7`](https://renovatebot.com/diffs/npm/@nx%2fvite/18.0.5/18.0.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/exporter-prometheus](https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-prometheus) ([source](https://github.com/open-telemetry/opentelemetry-js)) | [`^0.48.0` -> `^0.49.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fexporter-prometheus/0.48.0/0.49.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation) ([source](https://github.com/open-telemetry/opentelemetry-js)) | [`^0.48.0` -> `^0.49.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2finstrumentation/0.48.0/0.49.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/instrumentation-http](https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-http) ([source](https://github.com/open-telemetry/opentelemetry-js)) | [`^0.48.0` -> `^0.49.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2finstrumentation-http/0.48.0/0.49.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/sdk-node](https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-node) ([source](https://github.com/open-telemetry/opentelemetry-js)) | [`^0.48.0` -> `^0.49.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fsdk-node/0.48.0/0.49.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [jotai-effect](https://github.com/jotaijs/jotai-effect) | [`^0.5.0` -> `^0.6.0`](https://renovatebot.com/diffs/npm/jotai-effect/0.5.0/0.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [yarn](https://github.com/yarnpkg/berry) ([source](https://github.com/yarnpkg/berry/tree/HEAD/packages/yarnpkg-cli)) | [`4.1.0` -> `4.1.1`](https://renovatebot.com/diffs/npm/yarn/4.1.0/4.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-s3)</summary> ### [`v3.525.0`](https://github.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#35250-2024-02-29) [Compare Source](https://github.com/aws/aws-sdk-js-v3/compare/v3.523.0...v3.525.0) **Note:** Version bump only for package [@​aws-sdk/client-s3](https://github.com/aws-sdk/client-s3) </details> <details> <summary>napi-rs/node-rs (@​node-rs/jsonwebtoken)</summary> ### [`v0.5.1`](https://github.com/napi-rs/node-rs/releases/tag/%40node-rs/jsonwebtoken%400.5.1) [Compare Source](https://github.com/napi-rs/node-rs/compare/@node-rs/jsonwebtoken@0.5.0...@node-rs/jsonwebtoken@0.5.1) #### What's Changed - chore(deps): lock file maintenance by [@​renovate](https://github.com/renovate) in [https://github.com/napi-rs/node-rs/pull/800](https://github.com/napi-rs/node-rs/pull/800) - fix(jsonwebtoken): handle error in decodeHeader by [@​Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/napi-rs/node-rs/pull/801](https://github.com/napi-rs/node-rs/pull/801) **Full Changelog**: https://github.com/napi-rs/node-rs/compare/[@​node-rs/crc32](https://github.com/node-rs/crc32)[@​1](https://github.com/1).10.0...[@​node-rs/jsonwebtoken](https://github.com/node-rs/jsonwebtoken)[@​0](https://github.com/0).5.1 ### [`v0.5.0`](https://github.com/napi-rs/node-rs/releases/tag/%40node-rs/jsonwebtoken%400.5.0) [Compare Source](https://github.com/napi-rs/node-rs/compare/@node-rs/jsonwebtoken@0.4.0...@node-rs/jsonwebtoken@0.5.0) #### What's Changed - fix(jsonwebtoken): num typings by [@​tada5hi](https://github.com/tada5hi) in [https://github.com/napi-rs/node-rs/pull/777](https://github.com/napi-rs/node-rs/pull/777) - feat(jsonwebtoken): flatten claims to align with rfc by [@​tada5hi](https://github.com/tada5hi) in [https://github.com/napi-rs/node-rs/pull/780](https://github.com/napi-rs/node-rs/pull/780) - feat(jsonwebtoken): expose decode header utility by [@​tada5hi](https://github.com/tada5hi) in [https://github.com/napi-rs/node-rs/pull/795](https://github.com/napi-rs/node-rs/pull/795) - chore(\*): upgrade NAPI-RS cli and bindings by [@​Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/napi-rs/node-rs/pull/797](https://github.com/napi-rs/node-rs/pull/797) - feat(jsonwebtoken): support wasm32-wasi target by [@​Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/napi-rs/node-rs/pull/798](https://github.com/napi-rs/node-rs/pull/798) #### New Contributors - [@​tada5hi](https://github.com/tada5hi) made their first contribution in [https://github.com/napi-rs/node-rs/pull/777](https://github.com/napi-rs/node-rs/pull/777) **Full Changelog**: https://github.com/napi-rs/node-rs/compare/[@​node-rs/argon2](https://github.com/node-rs/argon2)[@​1](https://github.com/1).7.0...[@​node-rs/jsonwebtoken](https://github.com/node-rs/jsonwebtoken)[@​0](https://github.com/0).5.0 </details> <details> <summary>nrwl/nx (@​nx/vite)</summary> ### [`v18.0.7`](https://github.com/nrwl/nx/releases/tag/18.0.7) [Compare Source](https://github.com/nrwl/nx/compare/18.0.6...18.0.7) #### 18.0.7 (2024-03-04) ##### 🩹 Fixes - **core:** target defaults should represent nx.json in source info ([#​22080](https://github.com/nrwl/nx/pull/22080)) - **nextjs:** Add spec files when creating a next app ([#​22079](https://github.com/nrwl/nx/pull/22079)) - **release:** skip lock file update if workspaces are not enabled ([#​22055](https://github.com/nrwl/nx/pull/22055)) - **remix:** ensure component-testing is exported correctly [#​22091](https://github.com/nrwl/nx/issues/22091) ([#​22095](https://github.com/nrwl/nx/pull/22095), [#​22091](https://github.com/nrwl/nx/issues/22091)) - **storybook:** handle main.js file correctly in storybook plugin ([#​22081](https://github.com/nrwl/nx/pull/22081)) - **testing:** calculate correct support file path in cypress e2e preset ([#​22096](https://github.com/nrwl/nx/pull/22096)) ##### ❤️ Thank You - Austin Fahsl [@​fahslaj](https://github.com/fahslaj) - Colum Ferry [@​Coly010](https://github.com/Coly010) - Craigory Coppola [@​AgentEnder](https://github.com/AgentEnder) - Leosvel Pérez Espinosa [@​leosvelperez](https://github.com/leosvelperez) - Nicholas Cunningham [@​ndcunningham](https://github.com/ndcunningham) ### [`v18.0.6`](https://github.com/nrwl/nx/releases/tag/18.0.6) [Compare Source](https://github.com/nrwl/nx/compare/18.0.5...18.0.6) ##### 18.0.6 (2024-02-29) ##### 🩹 Fixes - **core:** nextjs-standalone generates package scripts consistent with create-next-app ([#​21996](https://github.com/nrwl/nx/pull/21996)) - **misc:** make sure to add e2e crystal plugin ([#​22041](https://github.com/nrwl/nx/pull/22041)) - **misc:** fix buildable libs utils calculating dependent projects from task graph ([#​22015](https://github.com/nrwl/nx/pull/22015)) - **node:** Increase timeout for CI ([#​22003](https://github.com/nrwl/nx/pull/22003)) - **nuxt:** fix storybook preview config path ([#​22020](https://github.com/nrwl/nx/pull/22020)) - **nuxt:** Add e2e-ci and serve-static targets ([#​22056](https://github.com/nrwl/nx/pull/22056)) - **release:** currentVersionResolver git-tag should prefer merged tags ([#​22082](https://github.com/nrwl/nx/pull/22082)) ##### ❤️ Thank You - Austin Fahsl [@​fahslaj](https://github.com/fahslaj) - Jack Hsu [@​jaysoo](https://github.com/jaysoo) - Katerina Skroumpelou [@​mandarini](https://github.com/mandarini) - Leosvel Pérez Espinosa [@​leosvelperez](https://github.com/leosvelperez) - Nicholas Cunningham [@​ndcunningham](https://github.com/ndcunningham) </details> <details> <summary>open-telemetry/opentelemetry-js (@​opentelemetry/exporter-prometheus)</summary> ### [`v0.49.1`](https://github.com/open-telemetry/opentelemetry-js/compare/7be35c7845e206b27b682e8ce1cee850b09cec04...3920b158d08daa776280bde68a79e44bafa4e8ea) [Compare Source](https://github.com/open-telemetry/opentelemetry-js/compare/7be35c7845e206b27b682e8ce1cee850b09cec04...3920b158d08daa776280bde68a79e44bafa4e8ea) ### [`v0.49.0`](https://github.com/open-telemetry/opentelemetry-js/compare/828f2ed730e4d26d71f92e220f96b60a552a673a...7be35c7845e206b27b682e8ce1cee850b09cec04) [Compare Source](https://github.com/open-telemetry/opentelemetry-js/compare/828f2ed730e4d26d71f92e220f96b60a552a673a...7be35c7845e206b27b682e8ce1cee850b09cec04) </details> <details> <summary>jotaijs/jotai-effect (jotai-effect)</summary> ### [`v0.6.0`](https://github.com/jotaijs/jotai-effect/releases/tag/v0.6.0) [Compare Source](https://github.com/jotaijs/jotai-effect/compare/v0.5.0...v0.6.0) #### What's Changed - rethrow errors thrown during effectFn and cleanup by [@​dmaskasky](https://github.com/dmaskasky) in [https://github.com/jotaijs/jotai-effect/pull/33](https://github.com/jotaijs/jotai-effect/pull/33) **Full Changelog**: jotaijs/jotai-effect@v0.5.0...v0.6.0 </details> <details> <summary>yarnpkg/berry (yarn)</summary> ### [`v4.1.1`](https://github.com/yarnpkg/berry/compare/52909a5e0d2fe72245957870bcd654218d93ef72...6b7621f0736ef7ed423672392882d68592d61c81) [Compare Source](https://github.com/yarnpkg/berry/compare/52909a5e0d2fe72245957870bcd654218d93ef72...6b7621f0736ef7ed423672392882d68592d61c81) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors thrown in the effect function are getting swallowed. I'm not sure exactly where they are getting swallowed but it might have something to do with the effect function running in the next microtask or perhaps something to do with React suspense.
This PR addresses this issue by saving the error to the ref object and then forcing a recalculation of the effectFn. The error is rethrown and the error is picked up by the ErrorBoundary.
Related Issue: #32