-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] [Accessibility] Gatherplots review #10
Comments
thanks for the ping, @domoritz. I'll open a quarto issue to track. |
Thanks for this @domoritz! I have some questions about some of the criteria and how we can make them work well. Adding @frankelavsky too since I think his opinion would be valuable. My first thought is: it would be helpful to have a sense of what is critical or not. Perhaps a distinction between "minimum requirements" versus "nice to have". Then we could give a paper a rating like "F (fail) / B (pass) / A / A+" or something like that in an infobox at the top of the paper. When I look at Chartability, I see some issues listed as "critical", maybe that's a starting point for establishing such levels? Some other thoughts:
Thanks again for all of this! |
We'd love to do this, but it'll be a while until we can get a design going. There's a 1.4 feature that lets you do something almost like what you want, but it would take multiple renders to get the different outputs (specifically, you can now use https://quarto.org/docs/authoring/conditional.html with checks for arbitrary metadata key-value pairs). Do note, critically, that this is not responsive. But I'd love to figure out a solution for you folks. |
I have just pushed changes addressing this accessibility review: #6. Here follows the revision response itself. Please let me know if some other format is expected for this!
I have improved the alt-text for all of the images in the article.
I have tried to make the images responsive by turning on the However, I have chosen not to modify images drawn from the Gatherplot implementations. This means that some of the labels, such as in Figure 1, are kept in their original size. Given that an interactive article is primarily intended to be viewed online, it should be possible to see images at full size.
While I appreciate this feedback, this functionality would require modifying the visualization and is thus not part of any of the Gatherplot implementations. I leave such features for future work.
As discussed above, I have chosen to not modify the original images from our Gatherplots implementation.
See above; we have chosen not to edit the visualization images but rather to make them larger.
I have tried to address font sizes to the extent possible.
This is a fair point. Unfortunately, we are presenting results from both our old Gatherplots implementation (no longer accessible), Observable Plot, and our own new Gatherplot implementation. They all provide slightly different functionality that I want to demonstrate in the article. I hope I have addressed all of the concerns, but I am happy to iterate on any issues that still persist. |
Thanks for the updates. These are great and I agree that it doesn't make sense to change the figures for the old implementation. I found three issues that need to be fixed. First, the issue with tooltips @cscheid commented on in #10 (comment) still exists and it making it almost impossible to navigate the document with a screen reader. This needs to be fixed in quarto but until it is, I would suggest disabling tooltips for references. Second, it's great that you broke up the images but the threshold for wrapping should be lower. Can you set a minimum image size? See how the images get super small on a narrow screen. Lastly, the screen reader experience for the plot charts is too noisy. Try navigating the document and you will find that all tick marks are navigated. Axes should be described in one AX element per axis or skipped and described in the description. Also, each mark in the scatterplot becomes its own accessibility element. It's probably best to group them so that one can skip over the group to reduce noise. See the last comment in the perceivable block at the top: "The article can be navigated comfortably with a screen reader. There are no unnecessary accessibility elements (e.g., axis ticks and labels) that clutter the screen reader experience." |
Can we have a followup about this at quarto-dev/quarto-cli#6500? |
I have disabled the tooltips for now. For the record, this is done by adding the following options to the HTML format block:
There seems to be no easy way to do this and maintain responsiveness. For now, I have added a min-width in a CSS class (.accessible-fig), but the responsive behavior no longer works. Pointers on how to achieve this are welcome, but at least the new version is easier to read. The results in Figure 12 and 13 are still in three-column format, but if need be I can change this as well.
Understood. This is an Observable Plot chart, however. I don't know how to change this short of reimplementing the scatterplot myself. |
I would suggest using css grid and change the number of columns based on the page width (using a media query). Alternatively, you could use fixed width images so that the number of columns changes based on the width as well.
Then I would say that we better hide the ax elements here and just rely on alt text until observable plot improves. |
I sent a pull request to improve plot to generate better aria values for axes by default: observablehq/plot#2018. You should still add custom aria for marks since plot doesn't do that automatically yet. |
Is there a simple solution here that doesn't require hacks around what quarto / observable plot are doing? I'd rather not require authors to implement a bunch of hacks around the systems they are using, as that adds a lot of additional burden on the author side. It seems like wasted effort to spend a lot of time on hacks around accessibility issues that are likely to eventually be fixed upstream --- since once they are fixed, we can just recompile the paper here. To me this suggests not dropping down to custom CSS / HTML / etc to fix this, but to ask what are reasonable short term fixes within the bounds of quarto / observable in expectation that long term this will be solved upstream in observable plot and/or quarto (which both seem receptive to such fixes?). |
(FWIW, Dom, I really appreciate the work you're doing to push us to be better --- I just want to balance that against author burden in expectation of upstream changes. Since we're not a traditional there-is-exactly-one-canonical-version-of-a-paper journal, getting it right here isn't a one-shot deal, but a process.) |
@mjskay It's also possible that whatever short term fixes we adopt over time can be incorporated to the Quarto template. (See the tooltip disabling above for a concrete case) |
@cscheid definitely! We can collect those changes here: journalovi/jovi-template-quarto#12 |
Absolutely. I think my fix that landed way faster than I expected is already good enough. As long we keep updating observable plot I think what we have now is good enough. Hopefully I can make time to look into automatic aria descriptions for marks (similar to what we already have out of the box in Vega-Lite) for Plot at some point as well. I think that's what I love about living documents in e.g. jovi. We can make these improvements at the library levels and all documents that use the libraries can be updates to use the improvements. |
I think that concludes the review for this paper. I'll close the issue. Thanks everyone for the inputs, suggestions, comments, and making changes! |
awesome, thanks so much @domoritz! |
Perceivable
Screen reader
Browser
Comments on Perceivable
All images should have alt texts that describe the content.
The font sizes of the figures is too small, especially on mobile. You can also consider making the figures responsive and change the layout (e.g. horizontal to vertical arrangement of charts) when the screen width changes.
Right now, a lot of the figures rely on being able to differentiate colors. Try using different shapes in addition to color. For example, in figure 4a, you could use different shapes for survived and not survived.
I noticed that the tooltips for references open when the VO cursor is over a reference and then the cursor goes into the tooltip. It clutters the VO experience so it feels like it should be different. CC @cscheid for Quarto
Operable
Comments on Operable
No interactive elements and focus seem to work as expected.
Understandable
Comments on Understandable
The visual hierarchy of axis labels and axis titles could be improved. For example, increase the font size of titles or make them bold. Some charts already use this style.
Robust
button
tag.Comments on Robust
All good.
Assistive
Comments on Assistive
The density of labels is too high in some cases and the marks are very densely packed.
The formatting of some numbers could be improved.
Flexible
Comments on Flexible
As mentioned before, the font sizes in figures are too small on phones.
I found it somewhat difficult to follow some of the charts because they use very different visual styles (fonts, colors, font sizes, etc). This probably happened because the charts use different libraries. It would be good to use one familiar style. This would greatly improve understandability.
ORCID
0000-0002-3110-1053
The text was updated successfully, but these errors were encountered: