Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera permission behaviour #505

Merged
merged 14 commits into from
Jan 7, 2020

Conversation

ippschi
Copy link
Contributor

@ippschi ippschi commented Oct 18, 2019

Addresses #488

  • Important: Old behaviour does not change. If library is used as before, behaviour does not change
  • Showing the dialog if permission is missing is optional now but true as default (as before)
  • Message can be set optionally, either programmatically or via IntentIntegrator
  • New Activity result is set if permission is not granted
  • Programmers can react on the onActivityResult Intent and modify if a dialog should be shown by the library directly or not
  • Removes SDK 23 version checks since library uses API 24

@rkistner
Copy link
Member

Thanks for the PR. The library currently still supports "downgrading" to SDK 14, so we'll still need those API checks.

I'll review the rest in detail a little later.

@ippschi
Copy link
Contributor Author

ippschi commented Oct 25, 2019

I reverted the removal of the API checks to allow downgrading to SDK 14.

@rkistner
Copy link
Member

@anipp100 Thanks for the work. I haven't forgotten about this - will try to get to it soon.

@rkistner rkistner merged commit e0d3409 into journeyapps:master Jan 7, 2020
@rkistner
Copy link
Member

rkistner commented Jan 7, 2020

Thanks, released in 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants