Fixing MediaPlayer warnings; #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix warnings about stream types. Also removed unused import.
ANEWGALAXI
commented
Dec 12, 2020
Comment on lines
+97
to
+98
| mediaPlayer.setAudioAttributes(new AudioAttributes.Builder().setContentType( | ||
| AudioAttributes.CONTENT_TYPE_MUSIC).build()); |
There was a problem hiding this comment.
Fixes warning: W/MediaPlayer: Use of stream types is deprecated for operations other than volume control
There was a problem hiding this comment.
This is causing crashes in Android 4 devices(4.4.2 and 4.4.4).
AudioAttributes was added in API level 21.
StackTrace:
Fatal Exception: java.lang.NoClassDefFoundError: android.media.AudioAttributes$Builder
at com.google.zxing.client.android.BeepManager.playBeepSound(BeepManager.java:97)
at com.google.zxing.client.android.BeepManager.playBeepSoundAndVibrate(BeepManager.java:84)
at com.journeyapps.barcodescanner.CaptureManager$1.barcodeResult(CaptureManager.java:80)
at com.journeyapps.barcodescanner.DecoratedBarcodeView$WrappedCallback.barcodeResult(DecoratedBarcodeView.java:50)
at com.journeyapps.barcodescanner.BarcodeView$1.handleMessage(BarcodeView.java:52)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5584)
at java.lang.reflect.Method.invokeNative(Method.java)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084)
at dalvik.system.NativeStart.main(NativeStart.java)
ANEWGALAXI
commented
Dec 12, 2020
| @@ -94,23 +94,20 @@ public synchronized void playBeepSoundAndVibrate() { | |||
|
|
|||
| public MediaPlayer playBeepSound() { | |||
| MediaPlayer mediaPlayer = new MediaPlayer(); | |||
| mediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC); | |||
There was a problem hiding this comment.
Removed this line since it is a deprecated method. Replaced with setAudioAttributes method call.
ANEWGALAXI
commented
Dec 12, 2020
| import android.media.AudioManager; | ||
| import android.media.MediaPlayer; | ||
| import android.os.Vibrator; | ||
| import android.util.Log; | ||
|
|
||
| import java.io.Closeable; |
There was a problem hiding this comment.
Removed unused import
ANEWGALAXI
commented
Dec 12, 2020
Comment on lines
+101
to
+102
| mp.reset(); | ||
| mp.release(); |
There was a problem hiding this comment.
Calling reset before release should fix the following warning: W/MediaPlayer: mediaplayer went away with unhandled events
|
Thanks for the work - will get this out in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #586. I fixed the warnings I was getting related to MediaPlayer/BeepManager: