Move CameraConfigurationUtils to prevent clash with other ZXing libraries #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noted. At this point the code base has diverged enough that we should probably move everything to our own package. It would be a breaking change, so would be done in the next major release. |
|
Great, thanks for the quick merge! |
|
@rkistner Could you please release a new version of the library with this fix included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
CameraConfigurationUtilsexists incom.google.zxing:android-coreas well. If an app would have dependencies tozxing-android-embeddedas well ascom.google.zxing:android-core, this would lead to a build error.A simple solution for that is to move the class to a different namespace.