Add (poor) support for conditionals #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to have a deeper look into the code but it does not look so bad... I think we can merge that with a few changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I don't expect this to get merged in its current state, it is only tested for my usecase where I needed to only conditionally add types to the main tree. It also works for conditionals within types, but I have not tested it with instances. However, the way I implemented the actual parsing of the condition is hacky. It will currently only work on comparing strings or fields using 'contents'. Anyways, I'm putting it here in case it helps you in any way. If you put how you want it to work here I'll adjust how I implemented it.
Thanks