feat(app): Add workout filtering and sorting #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces filtering and sorting capabilities to the workout list view. This enhances the user experience by allowing users to easily find specific workouts based on various criteria. The changes include: - Add a new `WorkoutFilters` struct to encapsulate filter parameters. This allows for easier handling and validation of filter input. - Create new template functions to provide options for the different filters and sorting, such as `filterOptions`, `orderByOptions`, and `orderDirOptions`. - Implement the `WorkoutFilters` struct to handle filtering by workout type, and time period, and sorting based on specific fields. - Modify the `workoutsHandler` function to utilize the `WorkoutFilters` struct to apply filters to the database query. - Added filter elements to the workouts view, allowing users to select filters and apply them. These elements are dynamically populated with options from the new template functions. - Updated the database queries to support the new filtering and sorting logic. This involves using the new `GetDateLimitExpression` function to correctly handle time-based filters and adding support for sorting by different fields. All this is encapsulated within the new `WorkoutFilters` struct. - Add translations for the new filter options.
The `getWorkoutsFilters` function was not handling errors properly, which could lead to unexpected behavior. This commit modifies the function to return an error if binding fails and adds error handling in the `workoutsHandler` to redirect to the workouts page with the error. Additionally, the `AverageSpeed` and `AverageSpeedNoPause` fields in the `WorkoutData` struct were methods, and not fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces filtering and sorting capabilities to the workout list
view. This enhances the user experience by allowing users to easily find
specific workouts based on various criteria.
The changes include:
WorkoutFiltersstruct to encapsulate filter parameters. Thisallows for easier handling and validation of filter input.
sorting, such as
filterOptions,orderByOptions, andorderDirOptions.WorkoutFiltersstruct to handle filtering by workout type, andtime period, and sorting based on specific fields.
workoutsHandlerfunction to utilize theWorkoutFiltersstructto apply filters to the database query.
and apply them. These elements are dynamically populated with options from the
new template functions.
This involves using the new
GetDateLimitExpressionfunction to correctlyhandle time-based filters and adding support for sorting by different fields.
All this is encapsulated within the new
WorkoutFiltersstruct.