Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ added apla directive #1308

Merged
merged 1 commit into from
Jun 15, 2022
Merged

🏷️ added apla directive #1308

merged 1 commit into from
Jun 15, 2022

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

I wanted to use the APLA Feature for Alexa Repromts and saw that the type did not exist yet on the Alexa reprompt type. I also could not find a class for the APLA Render Document in general, which is why I added that, and added the possibility to add this both in the response itself as well as in the reprompt directives. The reprompt directives can only contain this one directive (see docs). I saw that these directives have corresponding classes with class-transformer decorators to transform JSON/Pojo Objects into instances. I was however not exactly sure when this transformation happens exactly. I tried to make my changes in a way that I saw in the other Directives / Response, but am not 100% sure, I have not forgotten. I tried using it with just adding a pojo directive to the reprompt, which seems to look good now. I'd be happy about feedback!

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig
Copy link
Member

Thank you @sadlowskij! We're planning to review this tomorrow

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me ✅

@jankoenig jankoenig merged commit 991f598 into jovotech:v4/dev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants