Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Alexa person profile support #1371

Merged
merged 3 commits into from
Jul 21, 2022
Merged

✨ Alexa person profile support #1371

merged 3 commits into from
Jul 21, 2022

Conversation

theBenForce
Copy link
Contributor

@theBenForce theBenForce commented Jul 8, 2022 •
edited
Loading

Proposed Changes

Adding support for the person profile API. Heavily copied from the existing customer profile API.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@theBenForce theBenForce changed the title draft: 🎉 Alexa person profile support 🎉 Alexa person profile support Jul 8, 2022
@theBenForce theBenForce marked this pull request as ready for review July 8, 2022 21:47
@theBenForce theBenForce changed the title 🎉 Alexa person profile support ✨ Alexa person profile support Jul 8, 2022
@jankoenig
Copy link
Member

Thank you @theBenForce ! 🎉

We'll take a look this week

@theBenForce theBenForce changed the base branch from v4/latest to v4/dev July 19, 2022 14:05
aswetlow
aswetlow approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@aswetlow aswetlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jankoenig
jankoenig approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @theBenForce! Docs look great, too ✅

@jankoenig jankoenig merged commit e00bfbd into jovotech:v4/dev Jul 21, 2022
@theBenForce theBenForce deleted the v4/feature/person-profile-api branch July 21, 2022 10:50
@jankoenig jankoenig mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswetlow aswetlow aswetlow approved these changes

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theBenForce @jankoenig @aswetlow