Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛💥 Fixes mergeInstances in output strategies #1375

Merged
merged 4 commits into from
Jul 21, 2022
Merged

🐛💥 Fixes mergeInstances in output strategies #1375

merged 4 commits into from
Jul 21, 2022

Conversation

aswetlow
Copy link
Member

Proposed Changes

Fixes merge handling for arrays in nativeResponse. Fixes #1356

This could break workarounds that try to bypass this bug.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow requested a review from jankoenig July 21, 2022 12:16
@jankoenig jankoenig changed the title 🐛 Fixes mergeInstances in output strategies 🐛💥 Fixes mergeInstances in output strategies Jul 21, 2022
@jankoenig jankoenig marked this pull request as ready for review July 21, 2022 15:14
@jankoenig jankoenig merged commit 90868ca into v4/dev Jul 21, 2022
@jankoenig jankoenig deleted the v4/fix/merge branch July 21, 2022 15:14
@jankoenig jankoenig mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswetlow @jankoenig