Skip to content

Commit

Permalink
BUG: Fixed regex in asv.conf.json (pandas-dev#17300)
Browse files Browse the repository at this point in the history
In pandas-dev#17293 I messed up the syntax. I
used a glob instead of a regex. According to the docs at
http://asv.readthedocs.io/en/latest/asv.conf.json.html#regressions-thresholds we
want to use a regex. I've actually manually tested this change and verified that
it works.

[ci skip]
  • Loading branch information
TomAugspurger authored and jowens committed Sep 20, 2017
1 parent 393bb19 commit 595e0a4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions asv_bench/asv.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@
// skipped for the matching benchmark.
//
"regressions_first_commits": {
"*": "v0.20.0"
".*": "v0.20.0"
},
"regression_thresholds": {
"*": 0.05
".*": 0.05
}
}

0 comments on commit 595e0a4

Please sign in to comment.