Fix browser back button with multiple dcc.Location

Multiple dcc.Location were replacing the others event handlers for 'popstate'. If any dcc.Location was unmounted, there was no event handler left fix plotly#1312
jowlo · Jun 1, 2023 · 7a8fe1b · 7a8fe1b
1 parent db23cdc
commit 7a8fe1b
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/components/dash-core-components/src/components/Location.react.js b/components/dash-core-components/src/components/Location.react.js
@@ -112,7 +112,10 @@ export default class Location extends Component {
     }
 
     componentDidMount() {
-        window.onpopstate = this.onLocationChange;
+        window.addEventListener(
+            'popstate',
+            this.onLocationChange
+        )
 
         window.addEventListener(
             '_dashprivate_pushstate',
@@ -122,7 +125,10 @@ export default class Location extends Component {
     }
 
     componentWillUnmount() {
-        window.onpopstate = () => {};
+        window.removeEventListener(
+            'popstate',
+            this.onLocationChange
+        )
         window.removeEventListener(
             '_dashprivate_pushstate',
             this.onLocationChange