Skip to content

Commit

Permalink
[api] remove CpuFeatures::SupportedFeatures() from CachedDataVersionT…
Browse files Browse the repository at this point in the history
…ag()

The code cache should be CPU-independent, we also do not actually check
this during the deserialization of code cache, so there is no need
to impose this in the embedder-facing CachedDataVersionTag() API.

Refs: nodejs/node#42566 (comment)

Change-Id: Ia1d677b949050add961af6fbf62c44342c061312
  • Loading branch information
joyeecheung committed Oct 28, 2023
1 parent 2465184 commit 1f0b6fc
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/api/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2884,9 +2884,8 @@ MaybeLocal<Module> ScriptCompiler::CompileModule(
}

uint32_t ScriptCompiler::CachedDataVersionTag() {
return static_cast<uint32_t>(base::hash_combine(
internal::Version::Hash(), internal::FlagList::Hash(),
static_cast<uint32_t>(internal::CpuFeatures::SupportedFeatures())));
return static_cast<uint32_t>(base::hash_combine(internal::Version::Hash(),
internal::FlagList::Hash()));
}

ScriptCompiler::CachedData* ScriptCompiler::CreateCodeCache(
Expand Down

0 comments on commit 1f0b6fc

Please sign in to comment.