This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
v3 validation fixes #958
Merged
v3 validation fixes #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These validations were added in #626 and should have been included in this method when it was written. (as done in v2.37.3)
This should have been done as part of #786 when that validation was introduced. (as done in v2.37.3)
…roduct This has been incorrect since the validation was introduced in #626. (as done in v2.37.3)
…ier future transition and fix some json schema constraints
They had a 1:N relationship in the schema but 1:1 in practice, so keeping them separate is extra complication that adds no value.
…ayout than the device also support more types of nesting data in fixture specifications
karenetheridge
added
api
tests
refactor
breaking
needs-shell
karenetheridge
requested review from
dustinryerson and
perigrin
as code owners
karenetheridge
added a commit
to joyent/kosh
that referenced
this pull request
Nov 27, 2019
karenetheridge
added a commit
to joyent/kosh
that referenced
this pull request
Nov 28, 2019
…under device It is now possible to test validations where a device's hardware_product is different from its device_location->rack_layout->hardware_product.
…ayout again The change in #903 prevented the device's (actual) hardware_product from being matched against the rack_layout's (intended) hardware_product, which was one of the side effects of this validation.
karenetheridge
force-pushed
the
ether/v3-validation-fixes
branch
from
2a664ed to
971f0d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many fixes pertaining to validations and hardware products.
/hardware_productendpoints must be fixed)