Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer's Guide Added #495

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Developer's Guide Added #495

merged 1 commit into from
Mar 18, 2019

Conversation

indianwhocodes
Copy link
Contributor

No description provided.

@indianwhocodes indianwhocodes self-assigned this Mar 7, 2019
Copy link
Contributor

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you work with Carol to proof read this?

@indianwhocodes indianwhocodes changed the base branch from master to release-branch March 12, 2019 23:51
@indianwhocodes
Copy link
Contributor Author

Carol notified for her feedback.

DEVELOPING.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@ccobine ccobine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The firstI added the suggestions to the PR. Please note that if this is a section in a larger development guide, we may circle back to this to adjust the headings and a few references for logic and flow.

DEVELOPING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
More Feedback from Elijah, Carol
@indianwhocodes indianwhocodes merged commit 0c74ca9 into TritonDataCenter:release-branch Mar 18, 2019
@indianwhocodes
Copy link
Contributor Author

This branch has been squashed and merged onto the release-branch.

@indianwhocodes indianwhocodes added this to the Development Doc milestone Mar 18, 2019
indianwhocodes added a commit that referenced this pull request Apr 8, 2019
* Fixing Issue#479 (#500)

* Follow-Up After Investigating Fixing#479 (#499)

* String Literals Refactored Commit

* Equals() Changes Commit

* Copyright Headers Commit

* Document MetricReporterSupplier Class, Additional Changes (#473)

* Remove invalid comments

* Added javadoc, Changed Exception Signature

* Remove Unused Exception, WhiteSpace-Consistency

* Added Author name

* Added source reference for Metrics

* Fixing Issue#480 (#496)

* Fixing Issue#480

* Elijah's Feedback

* JavaDoc description for skipping test

* Removed @test annotation, waiting on #474 to be merged

* Final Changes

* Refactoring, Add @test dependencies

* Developer's Guide Added (#495)

More Feedback from Elijah, Carol

* Fix 470 and Update MantaErrorCode Enum Values

Remove Duplicates with same rest codes

Remove Error Codes tagged Duplicated && Deprecated

Elijah's Feedback.

* Additional unit tests added

* Final Changes

* [maven-release-plugin] prepare release java-manta-3.4.0

* [maven-release-plugin] prepare for next development iteration

* [maven-release-plugin] prepare release java-manta-3.4.0

* [maven-release-plugin] prepare for next development iteration

* CHANGELOG Updates for Subsequent Release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants