This repository has been archived by the owner on May 4, 2018. It is now read-only.
Use .lib prefix only on MSVC builds by checking host_os (fix build on mingw) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not check for minimum kernel and glibc versions, just check that the kernel headers export the syscall number and invoke the syscall directly. Effectively bypasses glibc.
Fixes "Assertion failed: (revents == EV_LIBUV_KQUEUE_HACK), function uv__fs_event, file ../src/unix/kqueue.c, line 58."
Read/write locks are emulated with critical sections on Windows XP and Vista because those platforms don't have a (complete) native read/write lock API.
Requires nodejs/node-v0.x-archive#2148 to set host_os
|
Sorry @adammw, it appears this PR got overlooked. I think these issues have been resolved in the current master? |
|
@adamw I think this has been resolved. If not, please file another issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming host_os is set either by options.gypi or node's configure script (by nodejs/node-v0.x-archive#2148), we can use either the .lib version for windows visual studio builds, or without .lib (the .a version) for mingw or cross compile.
If host_os is not set, then we just default to target os, which would be "win" for msvc which would result in the same as what we already have...
Or is there a better way that doesn't modify the gyp files? (That would be good as it would mean I don't have to try and get v8 to do the same thing on their gyp files).