Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Support for HTTP PATCH Verb! #1907

Closed
wants to merge 2 commits into from
Closed

Support for HTTP PATCH Verb! #1907

wants to merge 2 commits into from

Conversation

almost
Copy link

@almost almost commented Oct 18, 2011

It's an actual RFC now, can we have Node.JS support for it please!

http://tools.ietf.org/html/rfc5789

@koichik
Copy link

koichik commented Oct 18, 2011

Can you sign the CLA?

@ThisIsMissEm
Copy link

LGTM, can we have a test for it?

@almost
Copy link
Author

almost commented Oct 19, 2011

I've signed the CLA (electronic version, my full name is "Thomas Parslow"). I've added a test as well, just checking that the method name gets passed through, hope that's ok!

@koichik koichik closed this in b0f78af Oct 19, 2011
@koichik
Copy link

koichik commented Oct 19, 2011

@almost - I squashed into a single commit, thanks!

@felixge
Copy link

felixge commented Oct 20, 2011

@koichik How come this patch be done in node and not in the parser repo first?

https://github.com/joyent/http-parser

@koichik
Copy link

koichik commented Oct 20, 2011

@felixge - It is src/node_http_parser.cc, not deps/http-parser/http-parser.c :)
http-parser has already supported PATCH method (nodejs/http-parser@eee6012).

@felixge
Copy link

felixge commented Oct 20, 2011

@koichik ohhh, my bad. I should have read the file name, duh : ). LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants