This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Support for HTTP PATCH Verb! #1907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you sign the CLA? |
|
LGTM, can we have a test for it? |
|
I've signed the CLA (electronic version, my full name is "Thomas Parslow"). I've added a test as well, just checking that the method name gets passed through, hope that's ok! |
|
@almost - I squashed into a single commit, thanks! |
|
@koichik How come this patch be done in node and not in the parser repo first? |
|
@felixge - It is |
|
@koichik ohhh, my bad. I should have read the file name, duh : ). LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an actual RFC now, can we have Node.JS support for it please!
http://tools.ietf.org/html/rfc5789