deps: update libuv to 1.5.0 #25141
deps: update libuv to 1.5.0 #25141
Conversation
The -fno-strict-aliasing flag was added to fix compilation warnings when building Node.js with GCC <= 4.4 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #9179
|
@joyent/node-coreteam Adding to the 0.12.3 milestone, it would be great to have a few members of the core team reviewing this PR to determine if we want to include that in the upcoming v0.12.3 release. Thank you! |
| #define UV_VERSION_MINOR 4 | ||
| #define UV_VERSION_PATCH 2 | ||
| #define UV_VERSION_IS_RELEASE 0 | ||
| #define UV_VERSION_SUFFIX "node1" |
There was a problem hiding this comment.
Just so that we don't forget about that, if we need to float additional patches, we'll need to put back this version suffix.
|
I'm +1 to including it. |
|
LGTM |
|
@misterdjules those are all known failures on those platforms. 😞 |
|
@saghul Thank you again :) LGTM. |
Feel free to drop it when merging if need be :-) |
|
@saghul That won't be before landing this PR, see joyent/node-infra#4 for more context. Also, why bumping the minor version number? There doesn't seem to be any addition to the public API, unless I missed something. |
|
@misterdjules Ah, I see. Initially the minor number bump was due to the new APIs for customizing the memory allocator, but I ended up reverting those. Nevertheless, I decided to bump the minor since we ended up packing many bugfixes, some resulting in "sort of new features" such as the ability to swap stdout and stderr on child processes. A bit of a stretch, yeah, but numbers are free! :-) |
PR: nodejs#25141 PR-URL: nodejs#25141 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
The -fno-strict-aliasing flag was added to fix compilation warnings when building Node.js with GCC <= 4.4 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#9179 PR: nodejs#25141 PR-URL: nodejs#25141 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
|
@joyent/node-coreteam The node-accept-pull-request Jenkins job keeps failing because I made the decision to move forward with this and land this PR anyway since it was the only test failing, and I was able to make sure the test actually passes on two different Windows systems (2012 server and Windows 7). As a result, landed in 84f1ab6 and e1cc263. @orangemocha Would you mind taking a look at #25279? |
R=@trevnorris, @misterdjules