Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

deps: update libuv to 1.5.0 #25141

Closed
wants to merge 2 commits into from
Closed

deps: update libuv to 1.5.0 #25141

wants to merge 2 commits into from

Conversation

saghul
Copy link
Member

@saghul saghul commented May 6, 2015

saghul and others added 2 commits May 6, 2015 23:36
The -fno-strict-aliasing flag was added to fix compilation warnings when
building Node.js with GCC <= 4.4

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: #9179
@misterdjules misterdjules added this to the 0.12.3 milestone May 7, 2015
@misterdjules
Copy link

@joyent/node-coreteam Adding to the 0.12.3 milestone, it would be great to have a few members of the core team reviewing this PR to determine if we want to include that in the upcoming v0.12.3 release. Thank you!

@misterdjules
Copy link

Thank you very much @saghul! Tests running on Windows and UNIX.

#define UV_VERSION_MINOR 4
#define UV_VERSION_PATCH 2
#define UV_VERSION_IS_RELEASE 0
#define UV_VERSION_SUFFIX "node1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so that we don't forget about that, if we need to float additional patches, we'll need to put back this version suffix.

@misterdjules
Copy link

All tests pass on UNIX and on Windows.

@cjihrig
Copy link

cjihrig commented May 7, 2015

I'm +1 to including it.

@trevnorris
Copy link

LGTM

@misterdjules
Copy link

@saghul The Node.js Jenkins CI has some tests failing on SmartOS and OSX. Does that look like genuine failures, flakey tests or anything to worry about to you?

EDIT: That's libuv tests, not the Node.js' tests suite.

@saghul
Copy link
Member Author

saghul commented May 8, 2015

@misterdjules those are all known failures on those platforms. 😞

@misterdjules
Copy link

@saghul Thank you again :) LGTM.

@saghul
Copy link
Member Author

saghul commented May 8, 2015

Just FYI, we should be able to remove that floating patch by using the RHEL developer toolset on our CentOS Jenkins agent. Hopefully someone will be able to do that work soon.

Feel free to drop it when merging if need be :-)

@misterdjules
Copy link

@saghul That won't be before landing this PR, see joyent/node-infra#4 for more context. Also, why bumping the minor version number? There doesn't seem to be any addition to the public API, unless I missed something.

@saghul
Copy link
Member Author

saghul commented May 8, 2015

@misterdjules Ah, I see.

Initially the minor number bump was due to the new APIs for customizing the memory allocator, but I ended up reverting those. Nevertheless, I decided to bump the minor since we ended up packing many bugfixes, some resulting in "sort of new features" such as the ability to swap stdout and stderr on child processes. A bit of a stretch, yeah, but numbers are free! :-)

@misterdjules
Copy link

misterdjules pushed a commit to misterdjules/node that referenced this pull request May 12, 2015
PR: nodejs#25141
PR-URL: nodejs#25141
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
misterdjules pushed a commit to misterdjules/node that referenced this pull request May 12, 2015
The -fno-strict-aliasing flag was added to fix compilation warnings when
building Node.js with GCC <= 4.4

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: nodejs#9179

PR: nodejs#25141
PR-URL: nodejs#25141
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
@misterdjules
Copy link

@joyent/node-coreteam The node-accept-pull-request Jenkins job keeps failing because test/simple/test-tls-server-verify.js takes more than 60 seconds to run on our Windows 2012 server Jenkins agent. It doesn't fail on that machine, it takes around 80 seconds and thus times out.

I made the decision to move forward with this and land this PR anyway since it was the only test failing, and I was able to make sure the test actually passes on two different Windows systems (2012 server and Windows 7).

As a result, landed in 84f1ab6 and e1cc263.

@orangemocha Would you mind taking a look at #25279?

trevnorris added a commit that referenced this pull request Jun 16, 2015
The -fno-strict-aliasing flag was added to fix compilation warnings when
building Node.js with GCC <= 4.4

PR: #25141

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: #25475
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants