Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes #446

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Misc bug fixes #446

merged 3 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. The logic for checking of existence of git files wasn't always workin…

    …g as expected due to searching the current directory rather than using the export folder.
    bclothier committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    734d835 View commit details
    Browse the repository at this point in the history
  2. Add a check when loading XML and verify it was successfully parsed. T…

    …his avoid generating a bad export where the data are not actually exported due to invalid XML being generated by Application.ExportXML. Unfortunately, if a table contains any characters that aren't valid for XML document, it won't try to escape them and include them as literals. Even if they were escaped, they might not be accepted anyway. XML specifications forbids having any characters in 0x01-0x31 range so if a table data contains such characters, this can cause the XML export to fail. In this case, tab delimited will have to be used instead. However, the previous version was simply silently exporting as if everything is hunky-dory when it's not. Hence, the error.
    bclothier committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4703b7b View commit details
    Browse the repository at this point in the history
  3. The export log was littered with bunch of warnings about unclosed blo…

    …cks. This seems to be due to not closing it when evaluating the UseTheme. Even if we skipped it, we still need to remove it from m_colBlocks to balance everything out.
    bclothier committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0d9ac0a View commit details
    Browse the repository at this point in the history