Improve the email field validation in the home page #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
approved these changes
Oct 17, 2024
|
That my friend @amisevsk was a bug :D nice catch. Updated it to suppot common email characters like |
gorkem
requested changes
Oct 17, 2024
| @@ -125,6 +125,7 @@ const subscribeToNewsletter = async () => { | |||
| :disabled="isBusy" | |||
| id="email" | |||
| type="email" | |||
| pattern="^[a-zA-Z0-9]+(?:\.[a-zA-Z0-9]+)*@[a-zA-Z0-9]+(?:\.[a-zA-Z0-9]+)*$" | |||
There was a problem hiding this comment.
Can we improve it so that we allow for name+test@mymail.com kind of mails?
There was a problem hiding this comment.
yeah, i just push a fix right before this comment :D it was my mistake, give it another try
There was a problem hiding this comment.
This is the commit b550fd0
gorkem
approved these changes
Oct 17, 2024
javisperez
deleted the
464-ui-update-the-email-pattern-regex-from-forms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a custom (better?) regexp pattern to validate emails in the newsletter subscription form.