Some cleanup of config.py #2
Conversation
| else: | ||
| if len(key_paths) > 1: | ||
| for path in key_paths: | ||
| basename = os.path.basename(path) |
There was a problem hiding this comment.
this should be changed to basename = os.path.basename(path[0]) as the path that gets passed into there is already a tuple
There was a problem hiding this comment.
This would get fixed if the other issue gets fixed, don't worry about it for now
|
|
||
| if self.get_update_status() is None: | ||
| self.set_update(True) | ||
|
|
||
| if self.get_color() is None: | ||
| self.write_color('DarkBlue3') | ||
|
|
||
| def write_key_path(self, key_path: tuple): | ||
| def write_key_paths(self, *key_paths): |
There was a problem hiding this comment.
should remove the * due to anything being passed into it is already a tuple by force.
There was a problem hiding this comment.
I opted for an argument pack (as well as changing the name of the function) because the function takes variable number of arguments, "one or more key paths for the config to write". While it can be done the same with a single iterable argument, I thought this was a little bit cleaner. That said I am happy to revert this one if you prefer it without the pack. Do note though that in the absence of type-checking, the : tuple annotation doesn't actually force key_paths to be a tuple.
There was a problem hiding this comment.
i'm just saying that the only time we use that function is when we pass in a tuple, so the * doubles the tuple. it would be greatly appreciated if the * was removed
|
I had neglected to update main.py before, but I've now fixed both the name, and the issue with unpacking the tuple. |
No description provided.