-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EdDSA algorithm encoding/decoding usage #993
Conversation
@jpadilla, if possible, could you review the PR? Thanks :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! mind updating and fixing conflicts?
4061ca1
to
1960fec
Compare
@jpadilla, I've resolved PR conflicts, please review this PR at your available time. Thanks! |
docs/usage.rst
Outdated
>>> print(encoded) | ||
eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJzb21lIjoicGF5bG9hZCJ9.yPJ7Ggb6aOZn38vNai8bBN6bgfcrzKXSTsdXeGsZGibnxSZrWDrWeB6p35f9RFkMnYgToe_eh4mgye5V6wj5DQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> print(encoded) | |
eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJzb21lIjoicGF5bG9hZCJ9.yPJ7Ggb6aOZn38vNai8bBN6bgfcrzKXSTsdXeGsZGibnxSZrWDrWeB6p35f9RFkMnYgToe_eh4mgye5V6wj5DQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to remove encoded
printing?
If we remove encoded
printing, I think the encoded
variable will be unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the exact string representation of the token matters less and can fail dockets.
encoded
is used in the decode step below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The encoded
presenting has been removed.
1960fec
to
5acba65
Compare
As title, adding the
EdDSA
algorithm to encode/decode usage.