Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code highlight gets cut when scroll is available #374

Closed
cgutierr-zgz opened this issue Nov 16, 2022 · 8 comments · Fixed by #383
Closed

Code highlight gets cut when scroll is available #374

cgutierr-zgz opened this issue Nov 16, 2022 · 8 comments · Fixed by #383
Labels
bug Something isn't working

Comments

@cgutierr-zgz
Copy link
Contributor

What happened?

When we use the highlight for a code snippet it gets cut off on the "overflowing scrolling part(?)"

I noticed this on Google chrome on my pixel 4a
Screenshot_20221116-174823

Theme version

2.4.1

Hugo version

0.15

What browsers are you seeing the problem on?

Chrome

Relevant Hugo log output

No response

@cgutierr-zgz cgutierr-zgz added the bug Something isn't working label Nov 16, 2022
@jpanther
Copy link
Owner

Thanks for the report, @cgutierr-zgz. I'll have a look into this and see if I can make some adjustments.

@jpanther jpanther added the wip Work in progress label Nov 21, 2022
@github-actions github-actions bot removed the wip Work in progress label Nov 21, 2022
@cgutierr-zgz
Copy link
Contributor Author

I think the problem does persist it even seems a bit more aggressive now

Screenshot_20221122-094841
Screenshot_20221122-094836

@jpanther
Copy link
Owner

Oh no! I tested this using Chrome too and had no issues, but unfortunately I don't have an Android phone to be able to test it on there directly. I take it you're using the highlight shortcode to insert the code block?

@jpanther jpanther reopened this Nov 22, 2022
@cgutierr-zgz
Copy link
Contributor Author

cgutierr-zgz commented Nov 22, 2022

Yes, this is an example from a post i made:

{{<highlight dart "hl_lines=12">}}
// ...
final carlosCubit = SettingsCubit('carlos');
final dimaCubit = SettingsCubit('dima');
// ...

class SettingsCubit extends HydratedCubit<Settings> {
  SettingsCubit(this._id) : super(const Settings(themeMode: ThemeMode.system));

  final String _id;

  @override
  String get id => _id;
  //... other methods
}
{{</highlight>}}

If there's anything i can test, lmk, btw it does happen on google chrome too

@cgutierr-zgz
Copy link
Contributor Author

Example from my chrome on mac -> Version 106.0.5249.119 (Official Build) (arm64)

using iphone XR view
Screenshot 2022-11-22 at 10 04 33
Screenshot 2022-11-22 at 10 04 38

using galaxy s8+

Screenshot 2022-11-22 at 10 04 53

Screenshot 2022-11-22 at 10 04 49

Chrome without any emulator view

Screenshot 2022-11-22 at 10 07 36

@jpanther
Copy link
Owner

So it looks like there was some CSS caching going on in my Chrome and I've now been able to replicate this! Looking into it again now.

@jpanther jpanther added the wip Work in progress label Nov 22, 2022
jpanther added a commit that referenced this issue Nov 22, 2022
@jpanther
Copy link
Owner

I've created #383 so that you can have a look and see if this fixes your issue. I've tested it in Chrome and it appears to be working now. Feel free to use the deploy preview on the PR on your device and let me know if the problem has been resolved.

@cgutierr-zgz
Copy link
Contributor Author

Thanks @jpanther , it does look good now!

@github-actions github-actions bot removed the wip Work in progress label Nov 22, 2022
Nicceboy pushed a commit to ouspg/congo that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants