Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

author.image SmartCrop Issue #527

Merged
merged 1 commit into from
May 25, 2023
Merged

author.image SmartCrop Issue #527

merged 1 commit into from
May 25, 2023

Conversation

mchlebosz
Copy link
Contributor

When using author.image the image seems to be cropped, then rounded. It is not CSS as the image provided is already cropped.
The problem seems to be the SmartCrop feature of Hugo #526

The solution here is to define crop box placement explicitly: $authorImage.Fill "192x192 Center"
That way, no part of an image is lost when a 1:1 image is provided.

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dacf98f
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/642f4bcf4f039b0008930796
😎 Deploy Preview https://deploy-preview-527--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 7, 2023

This pull request has been automatically marked as stale because it has not had any recent activity.
Please review the PR history and add a reply with any requested information. If no information has been requested, it may be that this contribution does not fit with the project objectives, or does not adhere to the contributing guidelines. If this is in error, please add a reply with further details.
This PR will automactically close in 14 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label May 7, 2023
@metbril
Copy link
Contributor

metbril commented May 7, 2023

Keep?

@github-actions github-actions bot removed the stale This issue or pull request has not had any recent activity label May 8, 2023
@jpanther jpanther linked an issue May 25, 2023 that may be closed by this pull request
@jpanther
Copy link
Owner

Thanks for this fix, @mchlebosz. Apologies for taking so long to review the PR, I've been super busy! I think this should probably be a configurable parameter in the future, but for now this is a sensible default so I'm happy to merge it in.

@jpanther jpanther added the enhancement New feature or request label May 25, 2023
@jpanther jpanther merged commit ed21519 into jpanther:dev May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author Image file cropped
3 participants