-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: Lazy load image by default #552
Conversation
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the PR. I do wonder if this is something that should be added as a configurable parameter? Also, is there a reason you chose to only apply lazy loading to the markdown rendering template and not in other areas like the |
Sounds reasonable, should probably work on this.
Not really, that's my mistake in missing those, which should be set to lazy-load, too. Seems like we need to work on this more to support, I'll try to find some time. |
fe08b90
to
0d4fe03
Compare
@jpanther I think this is ready to go! |
Thanks for the changes, I think this is now a complete implementation and am happy to merge it in. It will be included in the next theme release. |
Welcome to getting moaned at by GTMetrix (Don't lazy load Largest Contentful Paint image) and Pagespeed (Largest Contentful Paint image was lazily loaded) for lazy loading. Above the fold shouldn't be lazy loaded, it actually just looks weird , and shifts text down when it appears. Better would be to not lazy load cover or featured image, then load rest - or make it option. none/all/notcover? |
Thanks @hystedm. I've opened a new issue #591 to track this. |
Make lazy loading images by default to reduce the load time on pages with many pictures.