-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Adjust metadata output #91
Conversation
✔️ Deploy Preview for hugo-congo ready! 🔨 Explore the source changes: 6313f69 🔍 Inspect the deploy log: https://app.netlify.com/sites/hugo-congo/deploys/61ede71fcd387a00074123fb 😎 Browse the preview: https://deploy-preview-91--hugo-congo.netlify.app |
Oh, I have not included my CSS fix to wrap the text around the metadata because I'm not sure if that's the best way to do it 😅 |
Thanks for the PR @cbelena. A very good first pull request! I'm happy with the changes however my only concern is that using the And yes don't worry about the CSS. I'll add a commit that addresses that part for you. It requires the Tailwind CSS to be recompiled. |
I'm also now wondering if we should pass the date into |
Sure! I reverted to
Wow, that was easy!! I have to learn more CSS! 😅😅 Thanks!
I have left it the same for now because it has a colon between the 'Update' and the date, like: PS: Oops, I forgot to add the globe emoji to the commit that updates the TR translation, sorry! |
The CSS turned out to be as simple as adding |
Hi @jpanther! Per discussion #88:
I have submitted two commits:
article.updated
string to the different languages available, making possible the translations to the last updated date in article's metadata. I've also updated the missing spanish translations of "word" and "words".date-updated.html
which adds the 'Updated' localized string and then calls thedate.html
partial. The new simplifieddate.html
also solves a little problem where before it displayed both the date and the updated date on pagination. Then, inarticle-meta.html
, instead of showing the last updated date in parentheses, I have treated it like another meta parameter.This is my first ever pull request, I'm sorry if I did something wrong 😅