XDG Base Directory Support

[ghost]

Could support of XDG Base Directories be considered? It would be nice to be freedesktop.org compliant and use XDG base directories by default. I know that this has been suggested before but nothing came of it. So instead of placing a hidden file directly in the home directory, placing it in $XDG_CONFIG_HOME/slack-term.json which is usually ~/.config/slack-term.json. This prevents home directory pollution which I personally can't stand.

[jrwrigh]

I was about to write an issue for this exact thing. It should probably still check $HOME/ for backwards compatibility sake. Unfortunately, I don't know Go so I can't fix the issue in a reasonable amount of time.

For anyone wanting to take a stab at it, it looks like all that would need to be changed is simply put some logic at the function on line 55-60 of main.go.

Simply a "check $XDG_CONFIG_HOME/, $HOME/.config/, and $HOME for slack-term.json,in that order" is all that'd be necessary from what I can see.

Edit: updated logic to the full XDG spec per @
BilLOPGVkPPn8z0JGJhgiAGNo9YAqpk5ruChl0F's comment

Edit2: Also, reminder to whoever does it to update the README.md to reflect the change.

[jrwrigh]

Also, repeat of #170 (though without the exact XDG terminology).

[ghost]

Note that the specification specifies that $XDG_CONFIG_HOME must be checked before falling back to $HOME/.config, before falling back to how it is now. Although I've never heard of anyone not setting XDG_CONFIG_HOME to $HOME/.config.

[ghost]

Some more background (besides the original Arch wiki link) for the unfamiliar:

https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/XDGConfigFolders?action=show&redirect=GnomeGoals%2FXDGConfigFolders

https://wiki.debian.org/XDGBaseDirectorySpecification

[jrwrigh]

Gotcha. I updated my comment in case anyone finds this and just reads my comment on the directories to be checked.

[lhanson]

I'm happy to write a patch for this, but was hoping to get some confirmation from @erroneousboat that this would be a feature which they'd merge. I've encountered the odd maintainer who is either recalcitrant to adhere to the XDG spec or is simply unresponsive and the PR just sits in limbo forever. Not saying that's the case here, but it's nice to ask first before expending the effort when I've got a list of other projects I use which could use the same attention.

[lhanson]

Patch submitted, ambitious users can run my branch if they don't want to wait for it to be merged.

Looking at the commit history and the number of dormant PRs open, it seems like this project isn't actively maintained or is only given sporadic attention. If @erroneousboat wants some help maintaining the project I'm sure some community members would be interested in having a more up-to-date repo! I don't even use Slack that much anymore but would be willing to help.

[jpbruinsslot]

Closing this in favour of #170