Improve config flow behavior for wrong i2c address

jpcornil-git · Jul 14, 2024 · b89d7dd · b89d7dd
1 parent 889617c
commit b89d7dd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/custom_components/mcp23017/__init__.py b/custom_components/mcp23017/__init__.py
@@ -202,6 +202,14 @@ async def async_get_or_create(hass, config_entry, entity):
     return component
 
 
+def i2c_device_exist(address):
+    try:
+        smbus2.SMBus(DEFAULT_I2C_BUS).read_byte(address)
+    except (FileNotFoundError, OSError) as error:
+        return False
+    return True
+
+
 class MCP23017(threading.Thread):
     """MCP23017 device driver."""
 

diff --git a/custom_components/mcp23017/config_flow.py b/custom_components/mcp23017/config_flow.py
@@ -5,6 +5,7 @@
 from homeassistant import config_entries
 from homeassistant.core import callback
 
+from . import i2c_device_exist
 from .const import (
     CONF_FLOW_PIN_NAME,
     CONF_FLOW_PIN_NUMBER,
@@ -79,10 +80,13 @@ async def async_step_user(self, user_input=None):
                     user_input[CONF_FLOW_PIN_NUMBER],
                 )
 
-            return self.async_create_entry(
-                title=self._title(user_input),
-                data=user_input,
-            )
+            if i2c_device_exist(user_input[CONF_I2C_ADDRESS]):
+                return self.async_create_entry(
+                    title=self._title(user_input),
+                    data=user_input,
+                )
+            else:
+                return self.async_abort(reason="Invalid I2C address")
 
         return self.async_show_form(
             step_id="user",