Update requirements for datetime and warnings about inaccuracy #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephyviewer 1.2.0 or later is needed for ``ephyviewer.MainViewer(datetime_format = ...)``, which was introduced into neurotic in #110.
Datetime may be inaccurate for more reasons than just pauses during acquisition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following release of ephyviewer 1.2.0, it is now possible to require it for
datetime_format.Also, I have discovered at least one more way (other than pauses during acquisition) by which the datetime stored in an AxoGraph file may be inaccurate: if the chart was created with "New chart" and not immediately run with "Run chart", the delay will introduce inaccuracy. The time when "New chart" was clicked is stored in the file, not when "Run chart" was clicked. Warnings and comments have been updated to reflect this.