Run the Google Drive authorization flow in a separate thread and disable interaction until complete #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also hides the metadata selector and replaces it with a message when the auth flow is triggered by the menu action. If the auth flow is triggered by a download instead, it will still run on the network thread, but the metadata selector won't be hidden. This is not ideal, but making the download-triggered case the same would be difficult.
neurotic already handles this.
The menu bar gets disabled only if the auth flow is triggered by the menu action. It does not get disabled if triggered by a download. This is not ideal, but making the download-triggered case the same would be difficult.
jpgill86
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app's main window would become unresponsive while the authorization flow was waiting for user input in the web browser if triggered by the "Request Google Drive authorization now" menu action. Now the flow is executed on a separate thread so the app can remain responsive.
An instructive message is also displayed in the main window, and all menus are disabled until the flow completes.