Upgrade protobuf messages to 2.6 for python3 compatibility #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: The current trunk of protobuf works without patching. However, the package in pypi is still not updated. |
|
Were these updated definitions created just by running "make update-gazebo" with the newer protobuf installed? They do appear to work on my machine in python2 at least. |
|
Haha, I didn't even notice the Makefile. However, it was generated using the same mechanism, and then the relative imports were modified as I noted above. Protobuf cannot generate relative imports, see protocolbuffers/protobuf#90 |
jpieper
added a commit
that referenced
this pull request
Dec 1, 2014
Upgrade protobuf messages to 2.6 for python3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated protobuf messages were generated using protoc 2.6. I had to modify the messages to use relative imports -- but that's pretty minor. Internal changes to the library means that the messages are not compatible with older versions of protobuf.
One more thing required to finish out #6 -- namely, protobuf needs a python 3 compatible release. I have a patched version.