Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check before casting $value to string when firing events #18

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

DennyLoko
Copy link
Contributor

@DennyLoko DennyLoko commented Oct 2, 2023

Firstly, I want to express my gratitude for your contribution to this library. Secondly, I appreciate @patrocle for investigating the issue and suggesting a solution in #16.

As @patrocle did not return to his pull request to address the test failures, I incorporated his code and made enhancements to resolve the issue without compromising the test results.

If you have any suggestions for code improvements or any other matters, please feel free to contact me.

Additionally, could you please add the hacktoberfest label to this pull request?

Thank you!

This was necessray because some types cannot be converted to string,
and it was throwing an exception when casting an Enum.

This work was done based on the PR opened by @patrocle on
jpkleemans#16
@jpkleemans
Copy link
Owner

Hi, i'm sorry for my late reply. Thanks for your PR! Do you have time to add a test for your addition?

@DennyLoko
Copy link
Contributor Author

Sure, will add some later today.

@jpkleemans jpkleemans merged commit de18768 into jpkleemans:master Dec 14, 2023
@jpkleemans jpkleemans mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants