Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added methods to add/remove etcd cluster members #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added methods to add/remove etcd cluster members #219

wants to merge 1 commit into from

Conversation

r0ps3c
Copy link

@r0ps3c r0ps3c commented Dec 10, 2016

Fixes #218

@coveralls
Copy link

coveralls commented Dec 10, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 87.549% when pulling b2e486e on r0p0s3c:master into 0d0145f on jplana:master.

@tobegit3hub
Copy link
Contributor

Looks good and really useful.

@r0ps3c
Copy link
Author

r0ps3c commented Jan 22, 2017

Great, is there anything else needed for this to be merged?

@lavagetto
Copy link
Collaborator

@r0p0s3c the code looks good, you should add tests before this can be merged

@lavagetto lavagetto self-requested a review February 12, 2017 12:16
lavagetto
lavagetto requested changes Feb 12, 2017
View reviewed changes
Copy link
Collaborator

@lavagetto lavagetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@socketpair socketpair mentioned this pull request Apr 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavagetto lavagetto lavagetto requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r0ps3c @coveralls @tobegit3hub @lavagetto