Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race between closing an observable and a subscriber polling #55

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jplatte
Copy link
Owner

@jplatte jplatte commented Jul 11, 2024

There might be more performant solutions, but this fixes the bug and doesn't show huge perf losses.

@jplatte
Copy link
Owner Author

jplatte commented Jul 11, 2024

Should set up loom tests at some point to better catch races like this.

@jplatte jplatte merged commit 9517fa4 into main Jul 11, 2024
6 checks passed
@jplatte jplatte deleted the fix-race branch July 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant