chore: Rename LimitBuf and SortBuf
#67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `LimitBuf` to `ArrayBuf` and `SortBuf` to `VecBuf`. The idea is to identify these buffers by their intrinsic properties (an array and a vector) instead of by their usages (inside `Limit` or `Sort`). It makes reusability easier for new types.
This patch introduces the `BUF_CAP` constant to replace to buffer capacities that is repeated in multiple places.
Hywan
force-pushed
the
chore-util-rename-buffers
branch
from
d4a6361 to
2ca1719
Compare
jplatte
reviewed
Jan 10, 2025
Comment on lines
+45
to
+46
| type ArrayBuf = Option<VectorDiff<T>>; | ||
| type VecBuf = SmallVec<[VectorDiff<T>; BUF_CAP]>; |
There was a problem hiding this comment.
Oh, now I remember why I didn't like this initially. These names only make sense for impl<T> VectorDiffContainerOps<T> for Vec<VectorDiff<T>>, not for impl<T> VectorDiffContainerOps<T> for VectorDiff<T>... Honestly, I'm back to strongly disliking the new names 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
LimitBuftoArrayBufandSortBuftoVecBuf.The idea is to identify these buffers by their intrinsic properties
(an array and a vector) instead of by their usages (inside
LimitorSort). It makes reusability easier for new types.Another patch adds the
BUF_CAPconstant to represent buffercapacities.