-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip install resolution #20
Conversation
…files used in code
…files used in code
…files used in code
This PR is to resolve bug, where some part of code will not work after pip install the repository either using pip install git+.. or pip install from pypi. The reason being during package time it configured to remove all the files under asset folder. The codes referencing some of the files will break. Test this by either doing pip install git+ https://github.com/jpmorganchase/QOKit.git@test_coverage_circuit_optimization and/or pip install from pypi test site. |
Thank you, @rajgane07! @HaoTy, can you confirm that this resolves #19 on your end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this fixes #19 on my end. Thanks!
Can you wait before merge? I want to check something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install works on my machine! @rajgane07, could we make sure (using e.g. grep
) that none of the file names under archives/
are mentioned anywhere in the code, and then delete the archives/
folder?
Looks great otherwise!
During pip packaging, json files/.npy files were getting excluded. This change fixes that issue. @rsln-s I created archives file after verifying there are no depenency in the code. I have removed archives folder too in this change. All can you please verify and review one more time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I confirmed that the install works locally. @rajgane07, feel free to merge
Qokit code uses few Json files for calculations, these have been added back