Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to jlpm, align with jupyter-fs, move back to typescript #278

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

painebot
Copy link
Contributor

@painebot painebot commented Jun 4, 2024

No description provided.

@painebot painebot force-pushed the tkp/jlpm branch 2 times, most recently from 920f399 to c6f6b2e Compare June 4, 2024 15:34
@timkpaine timkpaine changed the title Move to jlpm Move to jlpm, align with jupyter-fs, move back to typescript Jun 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 20.30075% with 106 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (0aa6f01) to head (20df359).
Report is 7 commits behind head on main.

Files Patch % Lines
js/src/run.ts 9.09% 44 Missing and 6 partials ⚠️
js/src/widget.ts 11.11% 32 Missing ⚠️
js/src/tool.ts 25.00% 11 Missing and 1 partial ⚠️
js/src/activate.ts 26.66% 11 Missing ⚠️
js/src/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #278       +/-   ##
===========================================
- Coverage   84.84%   67.06%   -17.78%     
===========================================
  Files          15       23        +8     
  Lines        1194     1579      +385     
  Branches      123      190       +67     
===========================================
+ Hits         1013     1059       +46     
- Misses        160      481      +321     
- Partials       21       39       +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkpaine timkpaine merged commit ebdfa08 into jpmorganchase:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants