Set Http protocol version #213
Conversation
Change allows for setting the highest http version protocol. Defaults to version 1.1
| HttpVersion definedVersion = null; | ||
| httpVersion = getVersion(ctx); | ||
| if(httpVersion != null && httpVersion.length() > 0) { | ||
| String[] versions = httpVersion.split(","); |
There was a problem hiding this comment.
I see you use a comma instead of a dot as the version separator. Wouldn't be better to use a dot as used by the HTTP protocol itself?
There was a problem hiding this comment.
Yeah I wrestled with this for a bit of time, the option was to go with a (.) the usual given that we have say 1.1/2.0 etc. I opted for the comma on semantics. Conceptually I was thinking that we don't want to tie the major version to the minor version, the onus is on the developer to ensure that they are setting the values correctly not on jpos to check the values.
There was a problem hiding this comment.
But are you OK if we change that to use a 'dot' and use split(".") instead of split(",") ? The rest of the code would be the same. It just feels more natural to set HTTP_VERSION to say "2.0" than "2,0".
There was a problem hiding this comment.
I agree with using a dot such as "1.1"; it's the natural separator.
There are really just a few HTTP versions in the wild, and 97% of the time it's "1.1".
If we care enough to make it explicit for our project, in the published context entry HTTP_VERSION, it's because we know that we're going to be working with exactly that version, and there's no point in worrying about "tie[ying] the major version to the minor version" .
There was a problem hiding this comment.
I'm very much ok with it, if you guys want to go with the dot separator then yes that's something I absolutely have no problems with that.
There was a problem hiding this comment.
Excellent. Thank you. Will do that right away.
Change allows for setting the highest http version protocol. Defaults to version 1.1