Avoid NPE on createBalanceCache. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With zero `maxId`, and if there didn't exist a `BalanceCache`. The created `BalanceCache` has a null `balance`, which in turn triggered an NPE on `getBalance0`.
ar
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With zero
maxId, and if there didn't exist aBalanceCache. The createdBalanceCachehad a nullbalance, which in turn triggered an NPE ongetBalance0.This PR ensures a non null balance is set for the newly created balance cache. It is set to ZERO, since if
maxIdis not zero the next if will set the correct balance, and ifmaxIdis zero the correct balance is zero.