fix: ignore state properties in attribute rule 43081j#202 (43081j#203)

Allows properties with `state: true` to have non-lowercase names without an attribute being specified
jpradelle · May 28, 2024 · ba7794c · ba7794c
1 parent fb4dcfe
commit ba7794c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/rules/attribute-names.ts b/src/rules/attribute-names.ts
@@ -37,7 +37,7 @@ const rule: Rule.RuleModule = {
           const propertyMap = getPropertyMap(node);
 
           for (const [prop, propConfig] of propertyMap.entries()) {
-            if (!propConfig.attribute) {
+            if (!propConfig.attribute || propConfig.state) {
               continue;
             }
 

diff --git a/src/test/rules/attribute-names_test.ts b/src/test/rules/attribute-names_test.ts
@@ -38,7 +38,14 @@ ruleTester.run('attribute-names', rule, {
         };
       }
     }`,
-    `class Foo extends Litelement {
+    `class Foo extends LitElement {
+      static get properties() {
+        return {
+          internalState: {type: String, state: true}
+        };
+      }
+    }`,
+    `class Foo extends LitElement {
       static get properties() {
         return {
           camelCase: {type: String, attribute: 'lowercase'}