-
Notifications
You must be signed in to change notification settings - Fork 773
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check and warn for the absence of fs.realpath.native (#953)
* Revert "Remove check for fs.realpath.native support, since it's everywhere (#887)" This reverts commit f4a880d. * Added warning and fallback support for missing fs.realpath.native Signed-off-by: Lam Wei Li <peteriman@mail.com> * Removed NodeJS check and fs.realpath.native fallback Signed-off-by: Lam Wei Li <peteriman@mail.com> * Leaving original listener intact during test and better phasing for warning Signed-off-by: Lam Wei Li <peteriman@mail.com> * Using done() for proper async test Signed-off-by: Lam Wei Li <peteriman@mail.com> * Updated comments for clarity Co-authored-by: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com> Co-authored-by: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com>
- Loading branch information
Showing
2 changed files
with
67 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bb0120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the native error and fixed it with
var fsRealpath = require("fs.realpath")