Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove secure-random from dev-deps #610

Merged
merged 1 commit into from
Aug 6, 2018
Merged

remove secure-random from dev-deps #610

merged 1 commit into from
Aug 6, 2018

Conversation

manidlou
Copy link
Collaborator

@manidlou manidlou commented Aug 5, 2018

Removed secure-random from dev deps.

@manidlou manidlou self-assigned this Aug 5, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.228% when pulling ca77783 on cleanup-dev-deps into fb3dda7 on v8-dev.

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanZim RyanZim merged commit 1977480 into v8-dev Aug 6, 2018
@RyanZim RyanZim deleted the cleanup-dev-deps branch August 6, 2018 12:28
@RyanZim RyanZim added this to the 8.0.0 milestone Aug 11, 2018
manidlou added a commit that referenced this pull request Apr 1, 2019
manidlou added a commit that referenced this pull request Apr 4, 2019
RyanZim pushed a commit that referenced this pull request May 11, 2019
* Remove secure-random from dev-deps (#610)

* fix ensureDir() doc

* moveSync: refactor to use renameSync

* copy*(): fix copying bind-mounted directories (#618)

* copy*(): fix copying bind-mounted dirs

* copy*(): fix case-insensitive-paths tests

* copy*(): refactor to check paths more efficiently

* destructure stats object after checking err

* move*(): check paths before moving

* move*(): add case-insensitive paths test

* remove unnecessary done callback from test

* copy*(): add new option checkPathsBeforeCopying

* update copy*() docs to include checkPathsBeforeCopying

* some reformatting

* copy*(): use fs.stat with bigint option

* move*(): refactor to use the internal stat functions

* move*(): add test for prevent moving identical

* disable graceful-fs in copy and move tests

* fix parsing node version

* tiny reformat

* update copy*() docs

* refactor parsing node version

* use semver to parse node version in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants