Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify to follow the rules of the new 'standard' and 'standard-markdown' #624

Closed
wants to merge 2 commits into from
Closed

Modify to follow the rules of the new 'standard' and 'standard-markdown' #624

wants to merge 2 commits into from

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 5, 2018

Upgrade standard.
Fix the error code.

@JPeer264
Copy link
Collaborator

JPeer264 commented Sep 5, 2018

@abetomo thanks for your PR, seems like some checks failed on Travis. Can you please resolve them?

@abetomo
Copy link
Contributor Author

abetomo commented Sep 5, 2018 •
edited
Loading

Thanks for the review.
standard-markdown seems to be bad. I will check the details.

@abetomo
Copy link
Contributor Author

abetomo commented Sep 5, 2018

Since it was a standard-markdown bug, I opened PR in that project.
zeke/standard-markdown#25

@abetomo
Copy link
Contributor Author

abetomo commented Sep 6, 2018

I added an argument as an interim fix until the zeke/standard-markdown#25 is merged.

@coveralls
Copy link

coveralls commented Sep 6, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 86.228% when pulling 08123b6 on abetomo:upgrade_standard into 402c1d0 on jprichardson:master.

@abetomo abetomo changed the title Modify to follow the rules of the new 'standard' Modify to follow the rules of the new 'standard' and 'standard-markdown' Sep 13, 2018
@abetomo
Copy link
Contributor Author

abetomo commented Sep 13, 2018

@JPeer264 I also upgraded the 'standard-markdown'.
Pass the test.

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 13, 2018

Changes LGTM, however, we're currently working on v8 in the v8-dev branch, and I'm afraid of merge conflicts here. @manidlou?

@manidlou
Copy link
Collaborator

I would say rebase this and merge it to v8-dev. We'll figure it out there!

JPeer264
JPeer264 approved these changes Sep 15, 2018
View reviewed changes
Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @manidlou is aware of the possible merge conflicts I'm approving this

@JPeer264
Copy link
Collaborator

Still needs a rebase though.

@mbargiel mbargiel mentioned this pull request Oct 17, 2018
Closed
@RyanZim
Copy link
Collaborator

RyanZim commented Nov 7, 2018

Closing in favor of #636.

@RyanZim RyanZim closed this Nov 7, 2018
@abetomo abetomo deleted the upgrade_standard branch November 7, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abetomo @JPeer264 @coveralls @RyanZim @manidlou