Modules #19
Merged
Modules #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a nice rebase, and a changelog entry 🙂 |
|
Also more tests for stuff like:
|
- each function now gets a `FunctionDescriptor`. - the descriptor is used to instantiate the function at runtime by the `CreateFunction` instruction. - added concept of module variables, which are globals scoped to a specific module. this allows functions to refer to globals from the module in which they were declared without conflicting with other modules' globals. - introduced `ModuleLoader` trait, which allows configuring where modules are loaded from, and the `ModuleRegistry` struct, which is used to store modules at runtime. - the root module still emits global accesses using `LoadGlobal` and `StoreGlobal` instructions. - also did some renaming (`desc` -> `descriptor`) and added a builder for configuring the `Hebi` instance.
- `class` -> `class instance` - `class def` -> `class`
- added `Import` and `ImportNamed` instructions - updated import syntax to match Python (mostly) - implemented module loading (except native modules)
- functions were not respecting module scope, because the module kind was kept per function. it's been changed to be per-emitter. - the result of `get_module_var` was not being assigned to the accumulator.
|
I think that's enough tests for now, ship it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Some things which the original plan didn't consider:
module_varsin it to be accessible.