Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle key.educational_note_paths in SourceKit output #823

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

johnfairh
Copy link
Collaborator

@johnfairh johnfairh commented Oct 15, 2024

We've never had straight arrays of strings before, this is new in Swift 6 ("key.educational_note_paths"):

{
  "\/Users\/johnf\/project\/JazzyEx\/JazzyEx\/JazzyEx.swift" : {
    "key.diagnostic_stage" : "source.diagnostic.stage.swift.parse",
    "key.diagnostics" : [
      {
        "key.column" : 12,
        "key.description" : "extraneous whitespace between attribute name and '('; this is an error in the Swift 6 language mode",
        "key.diagnostic_stage" : "source.diagnostic.stage.swift.parse",
        "key.educational_note_paths" : [
          "error-in-future-swift-version.md"
        ],
        "key.id" : "error_in_future_swift_version",
        "key.line" : 2,
        "key.severity" : "source.diagnostic.severity.warning"
      }
    ],
    "key.length" : 43,
...

Attempt refactor to remove the assumption causing the force-unwrap fail. New version runs the breaking code cleanly, passes the tests here, and also passes the full jazzy spec suite without breaking anything.

Fixes #821.

@johnfairh johnfairh merged commit 3db8072 into jpsim:main Oct 18, 2024
17 checks passed
@johnfairh johnfairh deleted the jf-edunotes branch October 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant